Переглянути джерело

refactor(photography): 将硬编码的中文状态值替换为常量

- 在 LoadingDialog 组件中将 '全部货号生成失败' 字符串提取为 ALL_FAILED_MESSAGE 常量
- 在 ProgressSteps 组件中将 '等待处理'、'正在处理'、'处理完成'、'处理失败' 状态值
  提取为 STATUS_WAITING、STATUS_PROCESSING、STATUS_COMPLETED、STATUS_FAILED 常量
- 更新组件中的条件判断逻辑以使用这些常量而不是硬编码字符串
- 保持组件的功能行为不变,仅优化代码可维护性
panqiuyao 1 день тому
батько
коміт
b2934c8ee4

+ 6 - 5
frontend/src/views/Photography/components/LoadingDialog.vue

@@ -45,12 +45,12 @@
       </el-button>
 
       <el-button
-          v-if="message  === allFailedText"
+          v-if="message === ALL_FAILED_MESSAGE"
           type="primary"
           class="action-button   button--primary1  mar-top-20"
           @click="visible = false"
       >
-        {{ message }}
+        {{ allFailedText }}
       </el-button>
     </div>
   </el-dialog>
@@ -95,9 +95,10 @@ const props = withDefaults(defineProps<Props>(), {
   onOpenFolder: () => {}
 })
 
-// 使用 i18n 默认值
-const defaultMessage = i18n.global.t('loadingDialog.processing')
-const defaultButtonText = i18n.global.t('loadingDialog.processComplete')
+// 后端返回的中文状态值常量
+const ALL_FAILED_MESSAGE = '全部货号生成失败'
+
+// 翻译后的值用于显示
 const allFailedText = i18n.global.t('loadingDialog.allFailed')
 
 const emit = defineEmits<{

+ 17 - 17
frontend/src/views/Photography/components/ProgressSteps.vue

@@ -9,13 +9,13 @@
       >
         <!-- 步骤圆圈 -->
         <div class="step-circle">
-          <div v-if="step.status === tCompleted.value" class="step-icon completed">
+          <div v-if="step.status === STATUS_COMPLETED" class="step-icon completed">
             <el-icon><Check /></el-icon>
           </div>
-          <div v-else-if="step.status === tProcessing.value" class="step-icon processing">
+          <div v-else-if="step.status === STATUS_PROCESSING" class="step-icon processing">
             {{ index + 1 }}
           </div>
-          <div v-else-if="step.status === tFailed.value" class="step-icon failed">
+          <div v-else-if="step.status === STATUS_FAILED" class="step-icon failed">
             <el-icon><Close /></el-icon>
           </div>
           <div v-else class="step-icon waiting">
@@ -28,7 +28,7 @@
           <div class="step-title">{{ step.name }}</div>
           <div class="step-status">
             {{ getStepTitle(step) }}
-            <div v-if="step.status !== tWaiting.value" class="step-details">
+            <div v-if="step.status !== STATUS_WAITING" class="step-details">
               {{ tCurrentProgress.value.replace('{current}', step.current).replace('{total}', step.total) }}
               {{ getCurrentGoodsNo(step) }}
               <span v-if="step.error" style="color: red; margin-left:5px;">{{ tFailedCount.value.replace('{count}', step.error) }}</span>
@@ -110,25 +110,25 @@ const getStepTitle = (step: StepData) => {
   return step.status
 }
 
-// 获取步骤样式类
+// 后端返回的中文状态值常量
+const STATUS_WAITING = '等待处理'
+const STATUS_PROCESSING = '正在处理'
+const STATUS_COMPLETED = '处理完成'
+const STATUS_FAILED = '处理失败'
+
+// 获取步骤样式类 - 使用后端返回的中文状态值
 const getStepClass = (step: StepData) => {
   return {
-    'step-completed': step.status === tCompleted.value,
-    'step-processing': step.status === tProcessing.value,
-    'step-failed': step.status === tFailed.value,
-    'step-waiting': step.status === tWaiting.value
+    'step-completed': step.status === STATUS_COMPLETED,
+    'step-processing': step.status === STATUS_PROCESSING,
+    'step-failed': step.status === STATUS_FAILED,
+    'step-waiting': step.status === STATUS_WAITING
   }
 }
 
-// 获取进度百分比
-const getProgressPercentage = (step: StepData) => {
-  if (step.total === 0) return 0
-  return Math.round((step.current / step.total) * 100)
-}
-
-// 检查是否所有步骤都完成
+// 检查是否所有步骤都完成 - 使用后端返回的中文状态值
 const allStepsCompleted = computed(() => {
-  return props.steps.every(step => step.status === '处理完成')
+  return props.steps.every(step => step.status === STATUS_COMPLETED)
 })
 
 // 获取当前货号(这里需要根据实际数据结构调整)