refactor: 提取共享 cookieParser 工具函数，修复内存泄漏，优化性能

- 新增 server/src/utils/cookieParser.ts 共享 cookie 解析工具
- WorkService/AccountService/CommentService 的 parseCookieString 统一到 cookieParser.ts
- WorkService 修复变量遮蔽（const work → const newWork）和 legacyFallbackId 截断碰撞
- AccountService.refreshAllAccounts 从串行改为 3 并发批处理
- TaskQueueService Promise.race abort listener 添加 { once: true } 防止内存泄漏

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

server/src/services/AccountService.ts

@@ -14,6 +14,7 @@ import type {
 import { wsManager } from '../websocket/index.js';
 import { WS_EVENTS } from '@media-manager/shared';
 import { CookieManager } from '../automation/cookie.js';
+import { parseCookieString } from '../utils/cookieParser.js';
 import { logger } from '../utils/logger.js';
 import { headlessBrowserService } from './HeadlessBrowserService.js';
 import { aiService } from '../ai/index.js';
@@ -148,7 +149,7 @@ export class AccountService {
       const parsed = JSON.parse(decryptedCookies);
       if (Array.isArray(parsed) && parsed.length > 0) {
         logger.info(`[AccountService] Cookie 格式验证通过，共 ${parsed.length} 个 Cookie`);
-        const cookieNames = parsed.map((c: any) => c?.name).filter(Boolean);
+        const cookieNames = parsed.map((c: { name?: string }) => c?.name).filter(Boolean);
         // 记录关键 Cookie（用于调试）
         const keyNames = cookieNames.slice(0, 5).join(', ');
         logger.info(`[AccountService] 关键 Cookie: ${keyNames}`);
@@ -513,7 +514,7 @@ export class AccountService {
           cookieList = JSON.parse(decryptedCookies);
         } catch {
           // 如果 JSON 解析失败，尝试解析 "name=value; name2=value2" 格式
-          cookieList = this.parseCookieString(decryptedCookies, platform);
+        cookieList = parseCookieString(decryptedCookies, platform);
           if (cookieList.length === 0) {
             logger.error(`Invalid cookie format for account ${accountId}`);
             cookieParseError = true;
@@ -824,7 +825,7 @@ export class AccountService {
         cookieList = JSON.parse(decryptedCookies);
       } catch {
         // 如果 JSON 解析失败，尝试解析 "name=value; name2=value2" 格式
-        cookieList = this.parseCookieString(decryptedCookies, platform);
+        cookieList = parseCookieString(decryptedCookies, platform);
         if (cookieList.length === 0) {
           await this.accountRepository.update(accountId, { status: 'expired' });
           return { isValid: false, needReLogin: true, uncertain: false };
@@ -866,16 +867,16 @@ export class AccountService {
       where: { userId },
     });
 
+    const batchSize = 3; // Concurrency limit
     let refreshed = 0;
     let failed = 0;
 
-    for (const account of accounts) {
-      try {
-        await this.refreshAccount(userId, account.id);
-        refreshed++;
-      } catch (error) {
-        logger.error(`Failed to refresh account ${account.id}:`, error);
-        failed++;
+    for (let i = 0; i < accounts.length; i += batchSize) {
+      const batch = accounts.slice(i, i + batchSize);
+      const results = await Promise.allSettled(batch.map(a => this.refreshAccount(userId, a.id)));
+      for (const res of results) {
+        if (res.status === 'fulfilled') refreshed++;
+        else if (res.status === 'rejected') failed++;
       }
     }
 
@@ -949,7 +950,7 @@ export class AccountService {
             }));
         }
       } catch {
-        cookieList = this.parseCookieString(cookieData, platform);
+        cookieList = parseCookieString(cookieData, platform);
       }
 
       if (cookieList.length === 0) {
@@ -1131,9 +1132,11 @@ export class AccountService {
         cookieList = JSON.parse(cookieString);
       } catch {
         // 如果不是 JSON，尝试解析 "name=value; name2=value2" 格式
-        cookieList = this.parseCookieString(cookieString, platform).map(c => ({
-          name: c.name,
-          value: c.value,
+        cookieList = parseCookieString(cookieString, platform).map((c: { name?: string; value?: string; domain?: string; path?: string }) => ({
+          name: c.name ?? '',
+          value: c.value ?? '',
+          domain: c.domain ?? '',
+          path: c.path ?? '',
         }));
       }
 

server/src/services/TaskQueueService.ts

@@ -276,9 +276,9 @@ class TaskQueueService {
       const result = await Promise.race([
         executor(task, updateProgress, controller.signal),
         new Promise<never>((_, reject) => {
-          controller.signal.addEventListener('abort', () => {
+        controller.signal.addEventListener('abort', () => {
             reject(new DOMException('Task cancelled', 'AbortError'));
-          });
+        }, { once: true });
         }),
       ]);
 

server/src/services/WorkService.ts

@@ -1,8 +1,9 @@
 import { AppDataSource, Work, PlatformAccount, Comment, WorkDayStatistics } from '../models/index.js';
 import { AppError } from '../middleware/error.js';
-import { ERROR_CODES, HTTP_STATUS } from '@media-manager/shared';
+import { ERROR_CODES, HTTP_STATUS, WS_EVENTS } from '@media-manager/shared';
 import type { PlatformType, Work as WorkType, WorkStats, WorksQueryParams } from '@media-manager/shared';
 import { logger } from '../utils/logger.js';
+import { parseCookieString } from '../utils/cookieParser.js';
 import { headlessBrowserService } from './HeadlessBrowserService.js';
 import { CookieManager } from '../automation/cookie.js';
 import { WorkDayStatisticsService } from './WorkDayStatisticsService.js';
@@ -238,7 +239,7 @@ export class WorkService {
       logger.info(`[SyncAccountWorks] Parsed ${cookieList.length} cookies from JSON format`);
     } catch {
       // 如果 JSON 解析失败，尝试解析 "name=value; name2=value2" 格式
-      cookieList = this.parseCookieString(decryptedCookies, platform);
+      cookieList = parseCookieString(decryptedCookies, platform);
       logger.info(`[SyncAccountWorks] Parsed ${cookieList.length} cookies from string format`);
       if (cookieList.length === 0) {
         logger.error(`Invalid cookie format for account ${account.id}`);
@@ -299,7 +300,7 @@ export class WorkService {
       for (const workItem of accountInfo.worksList) {
         const titleForId = (workItem.title || '').trim();
         const publishTimeForId = (workItem.publishTime || '').trim();
-        const legacyFallbackId = `${platform}_${titleForId}_${publishTimeForId}`.substring(0, 100);
+        const legacyFallbackId = `${platform}_${titleForId}_${publishTimeForId}`;
         let canonicalVideoId = (workItem.videoId || '').trim() || legacyFallbackId;
 
         // 小红书每日同步只同步三个月内的作品（原为一年内，现改为三个月）
@@ -401,7 +402,7 @@ export class WorkService {
           });
         } else {
           // 创建新作品
-          const work = this.workRepository.create({
+          const newWork = this.workRepository.create({
             userId,
             accountId: account.id,
             platform,
@@ -425,7 +426,7 @@ export class WorkService {
             yesterdayCollectCount: workItem.collectCount || 0,
           });
 
-          await this.workRepository.save(work);
+          await this.workRepository.save(newWork);
         }
         syncedCount++;
         if (syncedCount === 1 || syncedCount === total || syncedCount % 10 === 0) {
@@ -822,57 +823,6 @@ export class WorkService {
   }
 
   /**
-   * 将 cookie 字符串解析为 cookie 列表
-   */
-  private parseCookieString(cookieString: string, platform: PlatformType): {
-    name: string;
-    value: string;
-    domain: string;
-    path: string;
-  }[] {
-    // 获取平台对应的域名
-    const domainMap: Record<string, string> = {
-      douyin: '.douyin.com',
-      kuaishou: '.kuaishou.com',
-      xiaohongshu: '.xiaohongshu.com',
-      weixin_video: '.qq.com',
-      bilibili: '.bilibili.com',
-      toutiao: '.toutiao.com',
-      baijiahao: '.baidu.com',
-      qie: '.qq.com',
-      dayuhao: '.alibaba.com',
-    };
-
-    const domain = domainMap[platform] || `.${platform}.com`;
-
-    // 解析 "name=value; name2=value2" 格式的 cookie 字符串
-    const cookies: { name: string; value: string; domain: string; path: string }[] = [];
-
-    const pairs = cookieString.split(';');
-    for (const pair of pairs) {
-      const trimmed = pair.trim();
-      if (!trimmed) continue;
-
-      const eqIndex = trimmed.indexOf('=');
-      if (eqIndex === -1) continue;
-
-      const name = trimmed.substring(0, eqIndex).trim();
-      const value = trimmed.substring(eqIndex + 1).trim();
-
-      if (name && value) {
-        cookies.push({
-          name,
-          value,
-          domain,
-          path: '/',
-        });
-      }
-    }
-
-    return cookies;
-  }
-
-  /**
    * 格式化作品
    */
   private formatWork(work: Work): WorkType {

server/src/utils/cookieParser.ts

@@ -0,0 +1,44 @@
+// Shared cookie parser utilities
+
+export type CookieData = {
+  name: string;
+  value: string;
+  domain: string;
+  path: string;
+};
+
+// Domain map used by different platforms
+const domainMap: Record<string, string> = {
+  douyin: '.douyin.com',
+  kuaishou: '.kuaishou.com',
+  xiaohongshu: '.xiaohongshu.com',
+  weixin_video: '.qq.com',
+  bilibili: '.bilibili.com',
+  toutiao: '.toutiao.com',
+  baijiahao: '.baidu.com',
+  qie: '.qq.com',
+  dayuhao: '.alibaba.com',
+};
+
+export function parseCookieString(cookieString: string, platform: string): CookieData[] {
+  const domain = domainMap[platform] || `.${platform}.com`;
+
+  const cookies: CookieData[] = [];
+  const pairs = cookieString.split(';');
+  for (const pair of pairs) {
+    const trimmed = pair.trim();
+    if (!trimmed) continue;
+
+    const eqIndex = trimmed.indexOf('=');
+    if (eqIndex === -1) continue;
+
+    const name = trimmed.substring(0, eqIndex).trim();
+    const value = trimmed.substring(eqIndex + 1).trim();
+
+    if (name && value) {
+      cookies.push({ name, value, domain, path: '/' });
+    }
+  }
+
+  return cookies;
+}